Skip to content

Fix parent XO config resolution from nested package cwd#883

Open
sjh9714 wants to merge 2 commits into
xojs:mainfrom
sjh9714:fix-monorepo-package-config-resolution
Open

Fix parent XO config resolution from nested package cwd#883
sjh9714 wants to merge 2 commits into
xojs:mainfrom
sjh9714:fix-monorepo-package-config-resolution

Conversation

@sjh9714
Copy link
Copy Markdown

@sjh9714 sjh9714 commented May 17, 2026

Summary

Fixes XO config resolution when running from a nested package in a monorepo.

What changed

  • Added regression coverage for resolving a parent package.json XO config from a nested package cwd.
  • Updated config discovery to search parent project directories instead of stopping at the package parent directory.

Why

Issue #733 reports that packages in a monorepo do not pick up the root XO config. The previous search stopped before reaching the monorepo root.

Testing

  • npm run build
  • npm run test:setup
  • npx ava dist/test/resolve-config.test.js
  • node dist/cli.js lib/resolve-config.ts test/resolve-config.test.ts
  • git diff --check

Note: I also checked npm test; it currently stops at the lint step on both this branch and upstream/main with the same pre-existing @typescript-eslint/no-unnecessary-type-assertion reports in lib/utils.ts and lib/xo.ts.

Fixes #733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Projects in a Turborepo monorepo not using workspace package.json config

1 participant